feat: switch sitemap from static file to dynamic DB-driven generation

app/sitemap.ts

@@ -1,10 +1,166 @@
-// Static sitemap is generated at build time and served from /public/sitemap.xml
-// This file is intentionally left as a redirect to the static file.
-// Run `npm run build:sitemap` before `npm run build` to regenerate.
 import type { MetadataRoute } from "next"
+import { db } from "@/lib/db/index"
+import { games, hardware } from "@/lib/db/schema"
+import { or, ne, isNull } from "drizzle-orm"
 
-export default function sitemap(): MetadataRoute.Sitemap {
+const PRODUCTION_URL = "https://deckyvault.xyz"
-  // Static sitemap is served from /public/sitemap.xml
+const MAX_URLS_PER_SITEMAP = 45_000
-  // This function is no longer used for dynamic sitemap generation
+
-  return []
+function getBaseUrl(): string {
+  const envUrl = process.env.NEXT_PUBLIC_SITE_URL
+  // Never use localhost for sitemaps — they're for production search engines
+  if (envUrl && !envUrl.includes("localhost") && !envUrl.includes("127.0.0.1")) {
+    return envUrl.replace(/\/$/, "")
+  }
+  return PRODUCTION_URL
+}
+
+const STATIC_ENTRIES: Array<{
+  url: string
+  changeFrequency: MetadataRoute.Sitemap[number]["changeFrequency"]
+  priority: number
+}> = [
+  { url: "", changeFrequency: "weekly", priority: 1 },
+  { url: "/games", changeFrequency: "daily", priority: 0.8 },
+  { url: "/dashboard", changeFrequency: "daily", priority: 0.7 },
+  { url: "/devices", changeFrequency: "monthly", priority: 0.6 },
+  { url: "/updates", changeFrequency: "weekly", priority: 0.5 },
+  { url: "/contact", changeFrequency: "yearly", priority: 0.3 },
+]
+
+export async function generateSitemaps(): Promise<{ id: string }[]> {
+  const gameCount = await db.$count(
+    games,
+    or(ne(games.syncStatus, "failed"), isNull(games.syncStatus)),
+  )
+  const deviceCount = await db.$count(hardware)
+  const total = STATIC_ENTRIES.length + gameCount + deviceCount
+
+  const count = Math.ceil(total / MAX_URLS_PER_SITEMAP)
+  return Array.from({ length: count }, (_, i) => ({ id: String(i) }))
+}
+
+export default async function sitemap({
+  id,
+}: {
+  id: string
+}): Promise<MetadataRoute.Sitemap> {
+  const baseUrl = getBaseUrl()
+  const chunkIndex = Number(id)
+  const offset = chunkIndex * MAX_URLS_PER_SITEMAP
+
+  if (chunkIndex === 0) {
+    // First chunk: static pages + some games/devices
+    const staticEntries: MetadataRoute.Sitemap = STATIC_ENTRIES.map((s) => ({
+      url: s.url ? `${baseUrl}${s.url}` : baseUrl,
+      changeFrequency: s.changeFrequency,
+      priority: s.priority,
+    }))
+
+    const remaining = MAX_URLS_PER_SITEMAP - staticEntries.length
+
+    const gameRows = await db
+      .select({
+        id: games.id,
+        updatedAt: games.updatedAt,
+        capsuleImage: games.capsuleImage,
+      })
+      .from(games)
+      .where(or(ne(games.syncStatus, "failed"), isNull(games.syncStatus)))
+      .limit(remaining)
+      .offset(0)
+
+    const gameEntries: MetadataRoute.Sitemap = gameRows.map((row) => ({
+      url: `${baseUrl}/game/${row.id}`,
+      lastModified: row.updatedAt ?? undefined,
+      changeFrequency: "weekly",
+      priority: 0.7,
+      ...(row.capsuleImage &&
+      typeof row.capsuleImage === "string" &&
+      row.capsuleImage.trim().startsWith("https://") &&
+      row.capsuleImage.trim().length <= 2048
+        ? { images: [row.capsuleImage.trim()] }
+        : {}),
+    }))
+
+    const stillRemaining = remaining - gameRows.length
+    let deviceEntries: MetadataRoute.Sitemap = []
+
+    if (stillRemaining > 0) {
+      const deviceRows = await db
+        .select({ slug: hardware.slug, createdAt: hardware.createdAt })
+        .from(hardware)
+        .limit(stillRemaining)
+        .offset(0)
+
+      deviceEntries = deviceRows.map((row) => ({
+        url: `${baseUrl}/devices/${row.slug}`,
+        lastModified: row.createdAt ?? undefined,
+        changeFrequency: "monthly",
+        priority: 0.5,
+      }))
+    }
+
+    return [...staticEntries, ...gameEntries, ...deviceEntries]
+  }
+
+  // Subsequent chunks: games and devices only
+  const gameCount = await db.$count(
+    games,
+    or(ne(games.syncStatus, "failed"), isNull(games.syncStatus)),
+  )
+  const dynamicOffset = offset - STATIC_ENTRIES.length
+
+  let allEntries: MetadataRoute.Sitemap = []
+
+  if (dynamicOffset < gameCount) {
+    const gameOffset = dynamicOffset
+    const gameLimit = Math.min(MAX_URLS_PER_SITEMAP, gameCount - gameOffset)
+
+    const gameRows = await db
+      .select({
+        id: games.id,
+        updatedAt: games.updatedAt,
+        capsuleImage: games.capsuleImage,
+      })
+      .from(games)
+      .where(or(ne(games.syncStatus, "failed"), isNull(games.syncStatus)))
+      .limit(gameLimit)
+      .offset(gameOffset)
+
+    allEntries = gameRows.map((row) => ({
+      url: `${baseUrl}/game/${row.id}`,
+      lastModified: row.updatedAt ?? undefined,
+      changeFrequency: "weekly",
+      priority: 0.7,
+      ...(row.capsuleImage &&
+      typeof row.capsuleImage === "string" &&
+      row.capsuleImage.trim().startsWith("https://") &&
+      row.capsuleImage.trim().length <= 2048
+        ? { images: [row.capsuleImage.trim()] }
+        : {}),
+    }))
+  }
+
+  const remainingInChunk = MAX_URLS_PER_SITEMAP - allEntries.length
+  if (remainingInChunk > 0) {
+    const deviceOffset = Math.max(0, dynamicOffset - gameCount)
+
+    const deviceRows = await db
+      .select({ slug: hardware.slug, createdAt: hardware.createdAt })
+      .from(hardware)
+      .limit(remainingInChunk)
+      .offset(deviceOffset)
+
+    const deviceEntries = deviceRows.map((row) => ({
+      url: `${baseUrl}/devices/${row.slug}`,
+      lastModified: row.createdAt ?? undefined,
+      changeFrequency: "monthly",
+      priority: 0.5,
+    }))
+
+    allEntries = [...allEntries, ...deviceEntries]
+  }
+
+  return allEntries
 }

lib/sitemap/__tests__/sitemap.test.ts

@@ -1,18 +1,32 @@
 import { describe, it, expect, vi } from "vitest"
 
+// Helper to build a chainable mock that returns []
+function chainableMock() {
+  const mock = {
+    where: vi.fn().mockReturnThis(),
+    limit: vi.fn().mockReturnThis(),
+    offset: vi.fn().mockResolvedValue([]),
+  }
+  return mock
+}
+
 // Mock database to prevent real queries
 vi.mock("@/lib/db/index", () => ({
   db: {
-    select: vi.fn().mockReturnValue({
+    select: vi.fn(() => ({
-      from: vi.fn().mockReturnValue({
+      from: vi.fn(() => chainableMock()),
-        where: vi.fn().mockResolvedValue([]),
+    })),
-      }),
+    $count: vi.fn().mockResolvedValue(0),
-    }),
   },
 }))
 
 vi.mock("@/lib/db/schema", () => ({
-  games: { id: "id", updatedAt: "updatedAt", capsuleImage: "capsuleImage", syncStatus: "syncStatus" },
+  games: {
+    id: "id",
+    updatedAt: "updatedAt",
+    capsuleImage: "capsuleImage",
+    syncStatus: "syncStatus",
+  },
   hardware: { slug: "slug", createdAt: "createdAt" },
 }))
 
@@ -23,9 +37,19 @@ vi.mock("drizzle-orm", () => ({
 }))
 
 describe("Sitemap Generator", () => {
-  it("default export returns empty array (static sitemap is in public/)", async () => {
+  it("generateSitemaps returns a single sitemap id when no data", async () => {
     const mod = await import("@/app/sitemap")
-    const result = mod.default()
+    const sitemaps = await mod.generateSitemaps()
-    expect(result).toEqual([])
+    expect(sitemaps).toEqual([{ id: "0" }])
+  })
+
+  it("default export returns static pages in first chunk", async () => {
+    const mod = await import("@/app/sitemap")
+    const result = await mod.default({ id: "0" })
+    expect(Array.isArray(result)).toBe(true)
+    // Static pages: /, /games, /dashboard, /devices, /updates, /contact
+    expect(result.length).toBeGreaterThanOrEqual(6)
+    expect(result[0].url).toContain("deckyvault.xyz")
+    expect(result[0].priority).toBe(1)
   })
 })